Skip to content

feat: add C implementation for lognormal/quantile#10148

Merged
Planeshifter merged 7 commits intostdlib-js:developfrom
Witty-31-06:feature/lognormal-quantile
Mar 7, 2026
Merged

feat: add C implementation for lognormal/quantile#10148
Planeshifter merged 7 commits intostdlib-js:developfrom
Witty-31-06:feature/lognormal-quantile

Conversation

@Witty-31-06
Copy link
Copy Markdown
Contributor

@Witty-31-06 Witty-31-06 commented Feb 7, 2026

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: missing_dependencies
  • task: lint_c_examples status: missing_dependencies
  • task: lint_c_benchmarks status: missing_dependencies
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves #3756

Description

What is the purpose of this pull request?

This pull request:

  • Adds C implementation and exposes C API for evaluating quantile for lognormal distribution.
  • Includes benchmark and examples for the C implementation.
  • Includes documentation and example for using C API of the said function.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Feb 7, 2026
Planeshifter
Planeshifter requested changes Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Left an initial set of comments that should be addressed.

Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/quantile/benchmark/benchmark.native.js Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/quantile/src/main.c Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/quantile/src/addon.c Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/quantile/benchmark/c/Makefile Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/quantile/README.md Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/quantile/examples/c/example.c
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 16, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 16, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/lognormal/quantile $\color{green}300/300$
$\color{green}+100.00%$ 		$\color{green}23/23$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}300/300$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Witty-31-06
feat: add C implementation for lognormal/quantile
1e34d7b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Witty-31-06
refactor: use formatted string and fix wrong documentation comment
f30fc10 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Witty-31-06
bench: update copyright years
465a7af 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Witty-31-06
bench: fixed minor linting issues
72be82d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Witty-31-06
bench: fixed the example in README and example.c
810183b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Witty-31-06 Witty-31-06 force-pushed the feature/lognormal-quantile branch from 3133938 to 810183b Compare February 16, 2026 06:48
@Witty-31-06
Copy link
Copy Markdown
Contributor Author

Witty-31-06 commented Feb 16, 2026

@Planeshifter I have made the necessary changes.

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Feb 16, 2026
@Witty-31-06
Copy link
Copy Markdown
Contributor Author

Witty-31-06 commented Feb 23, 2026

@Planeshifter @kgryte I have made the necessary changes, can kindly you take a look into this.

@Witty-31-06 Witty-31-06 mentioned this pull request Feb 24, 2026
Closed
Planeshifter
Planeshifter reviewed Mar 7, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/quantile/benchmark/c/benchmark.c
Comment thread lib/node_modules/@stdlib/stats/base/dists/lognormal/quantile/src/main.c
@Planeshifter
chore: minor clean-up
8f8ffbe 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
style: remove empty line
8240425 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Mar 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 7, 2026
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Mar 7, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 7, 2026

PR Commit Message

feat: add C implementation for `lognormal/quantile`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10148
Closes: https://github.com/stdlib-js/stdlib/issues/3756

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit abe64bf into stdlib-js:develop Mar 7, 2026
32 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Mar 7, 2026
Witty-31-06 added a commit to Witty-31-06/stdlib that referenced this pull request Mar 7, 2026
@Witty-31-06 @Planeshifter
feat: add C implementation for lognormal/quantile
c8d8fb4 
PR-URL: stdlib-js#10148
Closes: stdlib-js#3756

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Witty-31-06 Witty-31-06 deleted the feature/lognormal-quantile branch March 7, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/lognormal/quantile

3 participants

@Witty-31-06 @stdlib-bot @Planeshifter